REFACTOR: Change property "desktop_class" to "desktop"#7150
Draft
Devin-Crawford wants to merge 21 commits intomainfrom
Draft
REFACTOR: Change property "desktop_class" to "desktop"#7150Devin-Crawford wants to merge 21 commits intomainfrom
Devin-Crawford wants to merge 21 commits intomainfrom
Conversation
Resolves issue #6506 Update private property "_desktop_class" to "_desktop_instance". Update unit tests
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7150 +/- ##
===========================================
- Coverage 83.42% 21.56% -61.87%
===========================================
Files 254 253 -1
Lines 77735 77656 -79
===========================================
- Hits 64848 16743 -48105
- Misses 12887 60913 +48026 🚀 New features to boost your workflow:
|
- Fix #7202 (incorrect handling of file) - Remove incorrectly handled debug statements. - Add unit test when using local repo to test example data.
cleans up its own directory after teardown, preventing race conditions when pytest-xdist workers tear down module-scoped file_tmp_root while function-scoped fixtures still need the directory.
- Add while loop in test_analyze.py test_3dl_analyze_setup()
… fix/local_example_download # Conflicts: # tests/system/solvers/test_analyze.py
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
# Conflicts: # tests/conftest.py
# Conflicts: # src/ansys/aedt/core/aedt_logger.py # src/ansys/aedt/core/application/design.py # src/ansys/aedt/core/desktop.py # src/ansys/aedt/core/maxwell.py # src/ansys/aedt/core/modeler/cad/primitives.py # src/ansys/aedt/core/rpc/rpyc_services.py # src/ansys/aedt/core/visualization/advanced/rcs_visualization.py # src/ansys/aedt/core/visualization/post/common.py # tests/system/general/test_design.py # tests/unit/extensions/test_kernel_converter.py # tests/unit/extensions/test_version_manager.py # tests/unit/test_utils.py
…me' into refactor/change_desktop_class_name # Conflicts: # tests/system/solvers/test_analyze.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue
#6506
Description
The property name
desktop_classis confusing since it is a class instance. This PRchanges the name
desktop_classtodesktopwhich is much more intuitive and meaningful.Unit tests are updated and passing.
The private property "_desktop_class" was changed to "_desktop_instance" which is more descriptive.
_odesktop remains unchanged.
Issue linked
#6506
Checklist